search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-admin]Add e2e tests for kn admin plugin #63

Closed xliuxu closed 3 years ago

xliuxu commented 4 years ago

E2E tests need to fill-up:

knative-prow-robot commented 4 years ago

Hi @lanceliuu. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zhanggbj commented 4 years ago

/ok-to-test

zhanggbj commented 4 years ago

Hi @evankanderson, would you please help to add @lanceliuu to knative org, he's mainly focused on knative/client-contrib now, thanks!

maximilien commented 4 years ago

@lanceliuu you can add your tests plan as a TODO / tasks list in the description of this PR.

xliuxu commented 4 years ago

/retest

xliuxu commented 4 years ago

/retest

xliuxu commented 4 years ago

/retest

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lanceliuu, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/admin/OWNERS](https://github.com/knative/client-contrib/blob/master/plugins/admin/OWNERS)~~ [zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zhanggbj commented 4 years ago

per offline discussion with @lanceliuu, this PR is the initial e2e setup and only cover domain subcommand. Other e2e are listed here #14 and will be covered by other subcommand stories. I think this looks good and we can merge it first and request e2e test for future PRs. Thanks!

CC @maximilien who helped to review this PR^^^

maximilien commented 4 years ago

OK @zhanggbj. Let's also edit the description of this PR and removing the unfinished TODOs and move them to the other list if not there.

/lgtm

zhanggbj commented 4 years ago

Hi @maximilien @daisy-ycguo @rhuss

The integration tests failed due to service creation failure. The Knative Ingress never becomes ready, it could be an error of e2e cluster side, any suggestions?

installing 'kn' plugin 'kn-source-kafka' from path '/home/prow/go/src/knative.dev/client-contrib/plugins/source-kafka' to config path: /root/.config/kn
--- FAIL: TestSourceKafka (646.32s)
    result_collector.go:75: ERROR: Error: timeout: service 'sinksvc' not ready after 600 seconds
        Run 'kn --help' for usage
    result_collector.go:101: === FAIL: =======================[[ERROR]]========================
        🦆 kn service create sinksvc --image gcr.io/knative-samples/helloworld-go --namespace kne2etests0
        ┃ Creating service 'sinksvc' in namespace 'kne2etests0':
        ┃ 
        ┃   0.143s The Configuration is still working to reflect the latest desired specification.
        ┃   0.258s The Route is still working to reflect the latest desired specification.
skipped 663 lines unfold_more
2020/07/31 09:12:15 process.go:155: Step '/tmp/kubernetes.D5Hjz6Osu0/e2e-test.sh' finished in 21m27.166505541s
2020/07/31 09:12:15 main.go:316: Something went wrong: encountered 1 errors: [error during /tmp/kubernetes.D5Hjz6Osu0/e2e-test.sh: exit status 1]
Test subprocess exited with code 1
Artifacts were written to /logs/artifacts
Test result code is 1
Step failed: test/e2e-tests.sh 
Step failed: default_integration_test_runner
          status:
            address:
              url: http://sinksvc.kne2etests0.svc.cluster.local
            conditions:
            - lastTransitionTime: "2020-07-31T08:59:50Z"
              status: "True"
              type: AllTrafficAssigned
            - lastTransitionTime: "2020-07-31T08:59:50Z"
              message: autoTLS is not enabled
              reason: TLSNotEnabled
              status: "True"
              type: CertificateProvisioned
            - lastTransitionTime: "2020-07-31T08:59:50Z"
              message: Ingress has not yet been reconciled.
              reason: IngressNotConfigured
              status: Unknown
              type: IngressReady
            - lastTransitionTime: "2020-07-31T08:59:50Z"
              message: Ingress has not yet been reconciled.
              reason: IngressNotConfigured
              status: Unknown
              type: Ready
maximilien commented 3 years ago

/test pull-knative-client-contrib-integration-tests

@lanceliuu can you dig into why above ^^^ is failing? thx.