search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[source-kafka] Fix error handling for kubeconfig #64

Closed daisy-ycguo closed 4 years ago

daisy-ycguo commented 4 years ago

Closes #58

The PR is to fix error handling of kubeconfig, including a dependency library upgrade.

navidshaikh commented 4 years ago

/assign

maximilien commented 4 years ago

Looks good to me. Holding to give @navidshaikh a chance for final review. Unhold as you see fit or I will next chance.

/hold /lgtm

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment