search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-admin]Add namespace and serviceaccount flag on kn admin registry #69

Closed 12345lcr closed 4 years ago

12345lcr commented 4 years ago

Fixes: https://github.com/knative/client-contrib/issues/68

knative-prow-robot commented 4 years ago

Hi @12345lcr. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
navidshaikh commented 4 years ago

/ok-to-test

zhanggbj commented 4 years ago

@12345lcr one more question, for my understanding, a default ServiceAccount is automatically created for each namespace, when a new Pod is created in the current namespace and it will use the default sa if sa not specified, so why we still need namespace flag using default sa here?

12345lcr commented 4 years ago

/ok-to-test

12345lcr commented 4 years ago

Hi @maximilien , I just addressed current comments and will start working on e2e test. Thanks!

maximilien commented 4 years ago

Hi @maximilien , I just addressed current comments and will start working on e2e test. Thanks!

Excellent. Please tag once e2e tests added and I will do another review pass. Thanks for contribution.

maximilien commented 4 years ago

LGTM... @zhanggbj feel free to merge when ready

zhanggbj commented 4 years ago

/lgtm

zhanggbj commented 4 years ago

/approve

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 12345lcr, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/admin/OWNERS](https://github.com/knative/client-contrib/blob/master/plugins/admin/OWNERS)~~ [zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment