search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

[kn-admin]As a Knative administrator, I want to upate autoscaling configs(global) which apply to overall Knative platform. #71

Open zhanggbj opened 4 years ago

zhanggbj commented 4 years ago

A developer may set some autoscaling configs like --limits-cpu or --limits-memory as what kn service create described today. However, a Knative administrator may need to update some overall configs like stable-window or panic-window-percentage or ticker-interval for the whole Knative platform. The kn-admin will list all the config we support to update by kn-admin

According the Knative 0.16 doc about autoscaling, plan support following global configs to help with admin work. (Per-revision config is not planned here, that are more for developer experience)

$ kn admin autoscaling update
- Stable-window xx
- panic-window-percentage xx
- max-scale-up-rate xx
- container-concurrency-target-default xx
- container-concurrency-target-percentage xx
- requests-per-second-target-default xx

If there're any other autoscale configs that should be controlled by Knative administrator, please feel free to leave a comment in this issue. Thanks!

zhanggbj commented 4 years ago

CC @maximilien @julz @duglin ^^^^^^

zhanggbj commented 4 years ago

/assign

duglin commented 4 years ago

I think you're missing:

Basically, everything in here: https://github.com/knative/serving/blob/66c2885ea639baa8fbdbe278e310b7b68d530c39/pkg/autoscaler/config/config.go#L43

zhanggbj commented 4 years ago

@duglin Thanks Doug for pointing this out! I already added the support to enable and disable scale-to-zero.

So in this PR I'll implement following flags for autoscaling global settings. The default setting will be consistent with values in knative doc