New Repo: knative-sandbox/kn-plugin-admin

rhuss commented 4 years ago

Repo information

Org: knative-sandbox

Repo: kn-plugin-admin

Purpose (Description): This repo holds the kn admin plugin which can be used to configure Kubernetes based Knative installations. Currently it is contained in a subdirectory of this client-contrib repo but we decided to move out all plugins into individual repostitories.

This issue replaces #73

Sponsoring WG: client

Actions to fulfill

This area is used for the TOC to track the repo creation process

[x] Add this issue to the TOC project board for review.
[x] Send a PR adding entries for this repo in /peribolos/knative-sandbox.yaml
- [x] Add the repository and a description.
- [x] Grant Knative Admin the admin privilege.
- [x] Grant the sponsoring WG the write privilege.
- PR: https://github.com/knative/community/pull/264

Once the TOC has approved the above, it will merge and Peribolos will create an empty repository.

[x] (golang) Send a PR to add aliases for knative.dev/$REPONAME import paths (sample).
[x] Have a lead from the sponsoring WG bootstrap the Git repository by pushing an appropriate "template" repository (basic, sample-controller, sample-source) to the new repository as a git remote. For example:
```
git clone https://github.com/knative-sandbox/sample-controller.git
cd sample-controller
git remote add newrepo https://github.com/knative-sandbox/$REPONAME.git
git push newrepo master
```
[x] Set up test-infra following the docs linked at the beginning.
[x] Create a sample PR to verify Prow (e.g. edit the boilerplate README)

Once Prow has been verified.

[x] Have a member of the TOC enable branch protections so that tide is a required presubmit check.

mattmoor commented 4 years ago

@evankanderson was it still your intention to do this (it is assigned to you still) given the new self-serve process?

@rhuss the new process should require minimal TOC action if you want to run through it to unblock.

rhuss commented 4 years ago

@mattmoor From the template it is not really clear to me what action items I can complete myself. Also it says

This area is used for the TOC to track the repo creation process

so I assumed that section is for the TOC only (btw, the link is not working but could be also because I copied over the template directly from @evankanderson not-yet-merged PR). Update: I just checked the merged version but the link still looks a bit bogus: ~https://github.com/mattmoor/community/blob/467457498c99f8b08c0739d8693abe88a8b11730/mechanics/CREATING-A-SANDBOX-REPO.md Shouldn't this point to a repo in the kantive orga ?~ the current template has the proper link. sorry missed that.

Send a PR adding entries for this repo in /peribolos/knative-sandbox.yaml

In which repo ?

Once the TOC has approved the above, it will merge and Peribolos will create an empty repository.

So it this really something I can do myself ?

The remaining parts are something I can do myself, but for this I would neet to have the repository created first, which is not yet the case.

Finally my question is where these kind of issues should be created ? in the knative/community or in the original repo that should be moved and this issue should be added to the TOC's project board ? There has been some discussion around this lately (cc @n3wscott )

rhuss commented 4 years ago

Ok, I think to understand now, so the actions are to be performed by the requestor, the checkmarks are to be filles by the requestor, too and TOC just acts on the gate steps (approving PRs and enabling branch protection).

I added some extra explanation with https://github.com/knative/community/pull/263 (which might be helpful to avoid confusion for other users, too)

mattmoor commented 4 years ago

This area is used for the TOC to track

Yeah we should tweak this to just say "used to track".

In which repo ?

knative/community. This should be a link.

So it this really something I can do myself

All you need from TOC is /approve on the PR to manipulate the org ACLs, so it's about as close to self-service as we can get, I think. Once the repo is created, as a WG lead you'll have write access to the new repo.

I added some extra explanation with

Cool, I added my comments above on your PR. thanks for the updates!

evankanderson commented 4 years ago

https://github.com/knative/website/pull/208 for the next steps

evankanderson commented 4 years ago

Just needs a /lgtm on https://github.com/knative/website/pull/208 to move to the next step.

mattmoor commented 4 years ago

@evankanderson I stamped it.

evankanderson commented 3 years ago

(Added Prow testing)

mattmoor commented 3 years ago

@evankanderson to follow up

evankanderson commented 3 years ago

Prow seems to be working, though it's not clear if tests are being run. @rhuss , are you expecting tests to run? It looks like only e2e tests are present.

mattmoor commented 3 years ago

Ping @rhuss

rhuss commented 3 years ago

Sorry for the delayed answer. Let me check ....

navidshaikh commented 3 years ago

here is the latest PR with prow configs for the plugin https://github.com/knative/test-infra/pull/2594 PTAL

evankanderson commented 3 years ago

Looks like this has been complete for a while.

/close

knative-prow-robot commented 3 years ago

@evankanderson: Closing this issue.

In response to [this](https://github.com/knative/client-contrib/issues/75#issuecomment-770439899): >Looks like this has been complete for a while. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

knative / client-contrib

New Repo: knative-sandbox/kn-plugin-admin #75

Repo information

Actions to fulfill