search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Add go.mod file to root to allow tests to pick the correct Golang version #82

Closed markusthoemmes closed 3 years ago

markusthoemmes commented 3 years ago

This ain't pretty, but it does the job and given that the repo is set to be sunset anyway, I'd just take that and run with it for now.

navidshaikh commented 3 years ago

/retest

imc-dispatcher-6b5c8b88d7-sgbh5 0/1 CrashLoopBackOff 5 5m16s

markusthoemmes commented 3 years ago

Crucially:

 Found go.mod file, using Go version 'go1.14' specified by it.
Switching Go version to 'go1.14'

This does what it's supposed to do!

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment