search

knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Bump kafka plugin deps to source-pkg 0.5.0 #83

Closed navidshaikh closed 3 years ago

navidshaikh commented 3 years ago

https://github.com/knative/client-contrib/pull/80 + fix for build tests

google-cla[bot] commented 3 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/source-kafka/OWNERS](https://github.com/knative/client-contrib/blob/master/plugins/source-kafka/OWNERS)~~ [navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
markusthoemmes commented 3 years ago

@navidshaikh I already did the same fix to my PR :thinking:

navidshaikh commented 3 years ago

/close

cool! thanks @markusthoemmes !

knative-prow-robot commented 3 years ago

@navidshaikh: Closed this PR.

In response to [this](https://github.com/knative/client-contrib/pull/83#issuecomment-712662225): >/close > >cool! thanks @markusthoemmes ! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.