knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

fix(kafka-plugin): Set bootstrapServers and Topics as arrays #86

Closed navidshaikh closed 3 years ago

navidshaikh commented 3 years ago

Fixes #https://github.com/knative/client-contrib/issues/85

Changes:

dsimansk commented 3 years ago

I think you need to bump CRD as well https://github.com/knative/client-contrib/blob/master/plugins/source-kafka/test/e2e-tests.sh#L45

Ad error:

 installing 'kn' plugin 'kn-source-kafka' from path '/home/prow/go/src/knative.dev/client-contrib/plugins/source-kafka' to config path: /root/.config/kn
    source_kafka_test.go:76: test kn-source-kafka create source-name
    result_collector.go:75: ERROR: cannot create KafkaSource 'mykafka1' in namespace 'kne2etests0' because: admission webhook "defaulting.webhook.kafka.sources.knative.dev" denied the request: mutation failed: cannot decode incoming new object: json: cannot unmarshal array into Go struct field KafkaSourceSpec.spec.bootstrapServers of type string 
knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[plugins/source-kafka/OWNERS](https://github.com/knative/client-contrib/blob/master/plugins/source-kafka/OWNERS)~~ [daisy-ycguo,navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
daisy-ycguo commented 3 years ago

/lgtm