Closed navidshaikh closed 3 years ago
I think you need to bump CRD as well https://github.com/knative/client-contrib/blob/master/plugins/source-kafka/test/e2e-tests.sh#L45
Ad error:
installing 'kn' plugin 'kn-source-kafka' from path '/home/prow/go/src/knative.dev/client-contrib/plugins/source-kafka' to config path: /root/.config/kn
source_kafka_test.go:76: test kn-source-kafka create source-name
result_collector.go:75: ERROR: cannot create KafkaSource 'mykafka1' in namespace 'kne2etests0' because: admission webhook "defaulting.webhook.kafka.sources.knative.dev" denied the request: mutation failed: cannot decode incoming new object: json: cannot unmarshal array into Go struct field KafkaSourceSpec.spec.bootstrapServers of type string
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: daisy-ycguo, navidshaikh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Fixes #https://github.com/knative/client-contrib/issues/85
Changes:
describe
command