knative / client-contrib

Community contributed `kn` plugins.
Apache License 2.0
10 stars 23 forks source link

Fix a few more occurrences of divisive language #87

Closed markusthoemmes closed 3 years ago

markusthoemmes commented 3 years ago

As per title.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-contrib/blob/master/OWNERS)~~ [rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
markusthoemmes commented 3 years ago

@daisy-ycguo would you please have a look at the tests? This seems unrelated, maybe we should just drop the code now?

evankanderson commented 3 years ago

/lgtm

markusthoemmes commented 3 years ago

/retest

navidshaikh commented 3 years ago

/retest

navidshaikh commented 3 years ago

We removed the tests https://github.com/knative/client-contrib/pull/88