search

knative / client-pkg

Reusable Knative client library
Apache License 2.0
3 stars 12 forks source link

:broom: Clean up the `kn` sub-package #155

Closed cardil closed 6 months ago

cardil commented 6 months ago

Changes

/kind cleanup

Fixes #152

Release Note

The knative.dev/client-pkg/pkg/kn was ditributed across the parent package knative.dev/client-pkg/pkg
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.57%. Comparing base (f170971) to head (2664fae). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #155 +/- ## ========================================== + Coverage 57.55% 57.57% +0.02% ========================================== Files 113 112 -1 Lines 8382 8379 -3 ========================================== Hits 4824 4824 + Misses 3297 3294 -3 Partials 261 261 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-pkg/blob/main/OWNERS)~~ [dsimansk,vyasgun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 6 months ago

/override codecov/project

knative-prow[bot] commented 6 months ago

@cardil: Overrode contexts on behalf of cardil: codecov/project

In response to [this](https://github.com/knative/client-pkg/pull/155#issuecomment-2009383379): >/override codecov/project Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.