search

knative / client-pkg

Reusable Knative client library
Apache License 2.0
3 stars 12 forks source link

:bug: Bubbletea initialization error handling #164

Closed cardil closed 7 months ago

cardil commented 7 months ago

Changes

/kind bug

Fixes #165 Walkaround charmbracelet/bubbletea#964

Release Note

UI initialization errors are not silenced
knative-prow[bot] commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 54.76190% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 57.56%. Comparing base (cf1573f) to head (ce1a548).

Files Patch % Lines
pkg/output/tui/progress.go 0.00% 10 Missing :warning:
pkg/output/tui/spinner.go 60.00% 2 Missing and 2 partials :warning:
pkg/output/tui/bubbletea964.go 81.25% 1 Missing and 2 partials :warning:
pkg/output/logging/context.go 0.00% 0 Missing and 1 partial :warning:
pkg/output/term/io.go 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== - Coverage 57.56% 57.56% -0.01% ========================================== Files 112 113 +1 Lines 8387 8415 +28 ========================================== + Hits 4828 4844 +16 - Misses 3298 3307 +9 - Partials 261 264 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cardil commented 7 months ago

/test unit-tests

cardil commented 7 months ago

/cc @dsimansk

cardil commented 7 months ago

With those changes, the CI build for magetasks passes, see: https://github.com/wavesoftware/go-magetasks/actions/runs/8434810274/job/23098848334?pr=44#step:5:211

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client-pkg/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment