search

knative / client-pkg

Reusable Knative client library
Apache License 2.0
3 stars 12 forks source link

Safeguard for charmbracelet/bubbletea#964 prevents using regular `stdin` #168

Closed cardil closed 7 months ago

cardil commented 7 months ago

The following block prevents from using regular stdin with tui.Spinner and tui.Progress:

https://github.com/knative/client-pkg/blob/ca2b56e0bc31b66c4d691d2d807b31fd084288da/pkg/output/tui/bubbletea964.go#L38-L45

The following situation happens:

$ go run github.com/cardil/repro-kn-cli-bad-license@latest
2024/03/27 11:37:43 WARN: non-regular file given as input:  stdin  (mode:  Dcrw--w---- ). Using `nil` as input.

/kind bug