search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Introduce --https flag which will add option to run all e2e tests with different http and https settings #1520

Open mvinkler opened 2 years ago

mvinkler commented 2 years ago

Feature request

Please introduce --https flag, similar to one in knative/serving: https://github.com/knative/serving/pull/5157

Use case

The flag will add option to run all e2e tests with different http and https settings. Currently, TestDomain test expects the first service to be available at http, and the second at https, but this may not be the case if "defaultExternalScheme" is set to https.

JuneOh710 commented 10 months ago

/assign

briheet commented 9 months ago

Hey @rhuss , if @JuneOh710 is not working on this issue, i would like to work on it as it interests me. Could you brief me a little about this ? I did look into feature request and the use case, could you touch on things where should i start with ?

JuneOh710 commented 9 months ago

Hey @rhuss , if @JuneOh710 is not working on this issue, i would like to work on it as it interests me. Could you brief me a little about this ? I did look into feature request and the use case, could you touch on things where should i start with ?

Hello, @briheet01. I took on this issue as a part of an initiative for undergrad students. I'm actually meeting with a member of knative today at 5pm EST to discuss this issue. Would it be possible for you to let us continue working on this issue?

briheet commented 9 months ago

@JuneOh710 Yeah sure, good luck.

asr2003 commented 4 months ago

@aliok Is this issue is ready to grab? I would like to explore the projects of our Knative community.

mabulgu commented 3 months ago

I want to work on this issue if no one is working on it yet. I am assigning it to myself but pls do unassign me if you have sbd else working on this one already. Note that my contributions might take time and if I am assigned to an issue this means I am genuinely working on it.

/assign

mabulgu commented 1 month ago

Sorry I needed to unassign this from myself as I could not find much time to work on this as I am going thru a difficult pace on my end.