knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

support uninstallation of local cluster using kn #1771

Closed viveksahu26 closed 1 year ago

viveksahu26 commented 1 year ago

Feature request

Currently, kn cli support installation of knative on kind and minikube cluster with the help quickstart plugin as a sub-command. But it was does not support to uninstall them.

For uninstallation of kind it should be: kn quickstart kind uninstall and for minikube: kn quickstart uninstall minikube uninstall

Use case

Provide a easiness to do that. Removes overhead from user. Beginner friendly.

UI Example

viveksahu26 commented 1 year ago

@aliok , I will love to take this.

aliok commented 1 year ago

cc @dsimansk

I am not 100% sure if we should have such functionality OR if we should simply add instructions to the "Uninstallation" section of the docs here that tells what to delete etc: https://knative.dev/docs/install/uninstall/

dsimansk commented 1 year ago

@viveksahu26 can you please follow up in the quickstart plugin repository? I can't move the issue due to different orgs.

https://github.com/knative-sandbox/kn-plugin-quickstart/issues

/cc @psschwei

psschwei commented 1 year ago

We do have a clean up section in the docs for how to delete quickstart clusters, but it's easy to miss given that it's in the tutorial

dsimansk commented 1 year ago

There are step by step instruction to remove the cluster. But for the local kind or minikube instances it's probably easier to recreate the whole cluster at once.

@viveksahu26 do you feel like quickstart uninstall would be still a valid addition? E.g. moving between Knative versions maybe?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.