knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Fixing some linter issues #1777

Closed rhuss closed 1 year ago

rhuss commented 1 year ago

Release Note

 Fix issue with newer linter version
codecov[bot] commented 1 year ago

Codecov Report

Base: 79.87% // Head: 79.88% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (05f4479) compared to base (dfc3c1e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1777 +/- ## ======================================= Coverage 79.87% 79.88% ======================================= Files 174 174 Lines 13595 13594 -1 ======================================= Hits 10859 10859 + Misses 1993 1992 -1 Partials 743 743 ``` | [Impacted Files](https://codecov.io/gh/knative/client/pull/1777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/printers/tablegenerator.go](https://codecov.io/gh/knative/client/pull/1777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3ByaW50ZXJzL3RhYmxlZ2VuZXJhdG9yLmdv) | `100.00% <100.00%> (ø)` | | | [pkg/errors/factory.go](https://codecov.io/gh/knative/client/pull/1777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2Vycm9ycy9mYWN0b3J5Lmdv) | `100.00% <0.00%> (+2.17%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dsimansk commented 1 year ago

Thanks!

/approve /lgtm

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk,rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment