Helloworld image running with non root user

knative / client

Knative developer experience, docs, reference Knative CLI implementation

Apache License 2.0

354 stars 261 forks source link

Helloworld image running with non root user #1787

Closed mgencur closed 1 year ago

mgencur commented 1 year ago

Description

Prevents error such as the following when the Pod security context has "runAsNonRoot": true::

"container has runAsNonRoot and image will run as root (pod: \"hello-00001-deployment-65676fb5b5-29mlc_tkn-kn0(930c61ec-28cf-46b8-8dad-d6d54e896b06)\", container: user-container)"

Changes

Dockerfile for helloworld runs as USER 65532

Reference

Fixes #

Release Note

dsimansk commented 1 year ago

/approve /lgtm

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment