knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Update and reorganise kn cli setup docs #1799

Closed garg-dhruv closed 1 year ago

garg-dhruv commented 1 year ago

Description

Resolves inconsistency in install instructions between docs/README.md and the official website. Resolution: Point user directly to official website and delete docs/README.md

Also, moving docs/DEVELOPMENT.md to root directory in alignment with other Knative projects.

Reference

Fixes #1410

knative-prow[bot] commented 1 year ago

Welcome @garg-dhruv! It looks like this is your first PR to knative/client 🎉

knative-prow[bot] commented 1 year ago

Hi @garg-dhruv. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dsimansk commented 1 year ago

Thanks for the PR! Welcome to the Knative community!

/ok-to-test

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (3a8d646) 79.87% compared to head (23685e8) 79.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1799 +/- ## ========================================== - Coverage 79.87% 79.85% -0.03% ========================================== Files 174 175 +1 Lines 13593 13633 +40 ========================================== + Hits 10858 10886 +28 - Misses 1992 2000 +8 - Partials 743 747 +4 ``` [see 3 files with indirect coverage changes](https://codecov.io/gh/knative/client/pull/1799/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dsimansk commented 1 year ago

/retest

dsimansk commented 1 year ago

/approve /lgtm

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, garg-dhruv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment