search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

HoldTillRename: Rename knative-sandbox to knative-extension #1815

Closed davidhadas closed 1 year ago

davidhadas commented 1 year ago

This is an automated PR to replace knative-sandbox strings to knative-extension. Do not merge until productivity renames knative-sandbox org to knative-extension.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidhadas Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/client/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (502d044) 79.70% compared to head (f7ed55e) 79.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1815 +/- ## ======================================= Coverage 79.70% 79.70% ======================================= Files 179 179 Lines 13850 13850 ======================================= Hits 11039 11039 Misses 2050 2050 Partials 761 761 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dsimansk commented 1 year ago

/hold

davidhadas commented 1 year ago

/retest

davidhadas commented 1 year ago

Seems like tests should be ok when knative-sandbox is renamed to knative-extension.

knative-prow[bot] commented 1 year ago

@davidhadas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-tests-latest-release_client_main f7ed55e2395aea30682c8a6979f919a56846db87 link true /test integration-tests-latest-release
integration-tests_client_main f7ed55e2395aea30682c8a6979f919a56846db87 link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).