knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Fix broker condition check #1820

Closed dsimansk closed 1 year ago

dsimansk commented 1 year ago

Description

This's changed on the Eventing end with latest nightly versions.

/cc @vyasgun @rhuss

Changes

Reference

Fixes #

Release Note

NONE
knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (cc1a637) 79.70% compared to head (e03a114) 79.70%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1820 +/- ## ======================================= Coverage 79.70% 79.70% ======================================= Files 179 179 Lines 13850 13850 ======================================= Hits 11039 11039 Misses 2050 2050 Partials 761 761 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dsimansk commented 1 year ago

@vyasgun if you may pls.

vyasgun commented 1 year ago

/lgtm