Closed dsimansk closed 1 year ago
Patch coverage: 82.92
% and project coverage change: +0.03
:tada:
Comparison is base (
00e38dc
) 79.70% compared to head (009b2e7
) 79.74%.:exclamation: Current head 009b2e7 differs from pull request most recent head c96dc6c. Consider uploading reports for the commit c96dc6c to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Please see my comment https://github.com/knative/client/pull/1821/files#r1242163943 that we should already add basic option handling here. Otherwise, I think it would break too much.
Also note the linter warnings.
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dsimansk, rhuss
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Description
This's handling a warning from API-server validation about SecurityContext being empty for
kn service create
and related cmds.I'll look into a few further improvements. E.g. either adding SecurityContext builder pattern or at least plain
--security-context seccon.yaml
flag to make it customizable./cc @rhuss @vyasgun
Changes
Reference
Fixes #
Release Note