search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

CLI: add support for experimental new filters API in trigger #1833

Open Cali0707 opened 1 year ago

Cali0707 commented 1 year ago

Feature request

As part of preparing the experimental new filters API to Beta (tracked here: https://github.com/knative/eventing/issues/5204), we should add support to kn to create these filters when creating a trigger.

Use case

With the new filters API entering Beta, more users will want to try it out. It would be convenient for them if they can use kn to create them, instead of being required to use yaml files to try out the new filters.

UI Example

kn trigger create mytrigger --new-filter filtertype=filtervalue
Cali0707 commented 1 year ago

@pierDipi @dsimansk @rhuss any thoughts on this?

dsimansk commented 1 year ago

@Cali0707 +1.

There's only support to display new filters, but not build/define. https://github.com/knative/client/pull/1794

Of course the tricky part is designing smooth UI elements for so many combinations possible.

pierDipi commented 1 year ago

@Cali0707 +1.

There's only support to display new filters, but not build/define. #1794

Of course the tricky part is designing smooth UI elements for so many combinations possible.

+1, we can also consider not supporting everything in the CLI as a starting point and reconsider later

rhuss commented 1 year ago

Could be a good candidate for the 48h Knative hackathon.

JuneOh710 commented 1 year ago

/assign

pierDipi commented 5 months ago

@dsimansk do you have a design/UI idea for this feature? In terms of what can be supported for the new trigger filters API?