Remove deprecated --inject-broker flag from trigger cmds

[xiangpingjiang]

Description

Changes

• remove deprecated --inject-broker flag
• remove related test

Reference

Fixes #1846

Release Note

Remove deprecated `--inject-broker` flag from `kn trigger` cmd group

[knative-prow[bot]]

Welcome @xiangpingjiang! It looks like this is your first PR to knative/client 🎉

[knative-prow[bot]]

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[codecov[bot]]

Codecov Report

Patch coverage has no change and project coverage change: -0.02% :warning:

Comparison is base (9676e46) 79.64% compared to head (0cf971a) 79.62%. Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1853 +/- ## ========================================== - Coverage 79.64% 79.62% -0.02% ========================================== Files 179 179 Lines 13938 13927 -11 ========================================== - Hits 11101 11090 -11 Misses 2070 2070 Partials 767 767 ``` | [Files Changed](https://app.codecov.io/gh/knative/client/pull/1853?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/kn/commands/trigger/create.go](https://app.codecov.io/gh/knative/client/pull/1853?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL3RyaWdnZXIvY3JlYXRlLmdv) | `67.64% <ø> (-3.02%)` | :arrow_down: | | [pkg/kn/commands/trigger/update\_flags.go](https://app.codecov.io/gh/knative/client/pull/1853?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL3RyaWdnZXIvdXBkYXRlX2ZsYWdzLmdv) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[dsimansk]

/ok-to-test

[dsimansk]

The failing E2E are unrelated to this PR, see #1854.

[xiangpingjiang]

The failing E2E are unrelated to this PR, see #1854.

@dsimansk

Thanks, I will try to fix it.

[xiangpingjiang]

/retest

[xiangpingjiang]

@dsimansk all tests passed, now can we merge this pr?

[dsimansk]

@dsimansk all tests passed, now can we merge this pr?

Sure, and once again thanks for fixing the deprecated API on the way. Greatly appreciated!

/approve /lgtm

[knative-prow[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment