knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

Upgrade deprecated v1alpha1 DomainMapping API to newer one #1856

Closed xiangpingjiang closed 1 year ago

xiangpingjiang commented 1 year ago

Description

Changes

Reference

Fixes #1854

Release Note

🐣 Upgrade deprecated `v1alpha1` DomainMapping API to `v1beta1`
knative-prow[bot] commented 1 year ago

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dsimansk commented 1 year ago

/ok-to-test

xiangpingjiang commented 1 year ago

/retest

xiangpingjiang commented 1 year ago

/retest

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9676e46) 79.64% compared to head (5734670) 79.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1856 +/- ## ======================================= Coverage 79.64% 79.64% ======================================= Files 179 179 Lines 13938 13938 ======================================= Hits 11101 11101 Misses 2070 2070 Partials 767 767 ``` | [Files Changed](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative) | Coverage Δ | | |---|---|---| | [pkg/kn/commands/completion\_helper.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2NvbXBsZXRpb25faGVscGVyLmdv) | `85.54% <100.00%> (ø)` | | | [pkg/kn/commands/domain/create.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2RvbWFpbi9jcmVhdGUuZ28=) | `75.51% <100.00%> (ø)` | | | [pkg/kn/commands/domain/delete.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2RvbWFpbi9kZWxldGUuZ28=) | `80.00% <100.00%> (ø)` | | | [pkg/kn/commands/domain/describe.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2RvbWFpbi9kZXNjcmliZS5nbw==) | `77.27% <100.00%> (ø)` | | | [pkg/kn/commands/domain/human\_readable\_flags.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2RvbWFpbi9odW1hbl9yZWFkYWJsZV9mbGFncy5nbw==) | `83.78% <100.00%> (ø)` | | | [pkg/kn/commands/domain/list.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2RvbWFpbi9saXN0Lmdv) | `66.66% <100.00%> (ø)` | | | [pkg/kn/commands/domain/update.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL2RvbWFpbi91cGRhdGUuZ28=) | `60.86% <100.00%> (ø)` | | | [pkg/kn/commands/types.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL2tuL2NvbW1hbmRzL3R5cGVzLmdv) | `82.60% <100.00%> (ø)` | | | [pkg/serving/v1beta1/client.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3NlcnZpbmcvdjFiZXRhMS9jbGllbnQuZ28=) | `85.71% <100.00%> (ø)` | | | [pkg/serving/v1beta1/client\_mock.go](https://app.codecov.io/gh/knative/client/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=knative#diff-cGtnL3NlcnZpbmcvdjFiZXRhMS9jbGllbnRfbW9jay5nbw==) | `88.09% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.