search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
354 stars 261 forks source link

:broom: Remove the vendor dir #1962

Closed cardil closed 3 months ago

cardil commented 3 months ago

Description

Remove the vendor dir. This should simplify the review of https://github.com/knative/client/pull/1953

Changes

/kind cleanup

Reference

Simplify https://github.com/knative/client/pull/1953 Closes https://github.com/knative/client/pull/1959

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.82%. Comparing base (de30b7b) to head (39b861d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1962 +/- ## ======================================= Coverage 76.82% 76.82% ======================================= Files 207 207 Lines 12892 12892 ======================================= Hits 9904 9904 Misses 2187 2187 Partials 801 801 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cardil commented 3 months ago

/override "style / Golang / Lint"

knative-prow[bot] commented 3 months ago

@cardil: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative/client/pull/1962#issuecomment-2315057455): >/override "style / Golang / Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cardil commented 3 months ago

/override "style / Golang / Lint"

knative-prow[bot] commented 3 months ago

@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint

In response to [this](https://github.com/knative/client/pull/1962#issuecomment-2315062212): >/override "style / Golang / Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dsimansk commented 3 months ago

/lgtm

dsimansk commented 3 months ago

/approve /lgtm

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dsimansk commented 3 months ago

/override "style / Golang / Lint"

knative-prow[bot] commented 3 months ago

@dsimansk: Overrode contexts on behalf of dsimansk: style / Golang / Lint

In response to [this](https://github.com/knative/client/pull/1962#issuecomment-2317738399): >/override "style / Golang / Lint" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.