search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
353 stars 261 forks source link

:gift: Allow to change the message for the spinner #1973

Closed cardil closed 3 weeks ago

cardil commented 4 weeks ago

Changes

Reference

Required for knative-extensions/kn-plugin-event#375

/kind enhancement

Release Note

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.70%. Comparing base (b3b6b86) to head (6b94cc6). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1973 +/- ## ========================================== + Coverage 73.68% 73.70% +0.01% ========================================== Files 234 234 Lines 16471 16482 +11 ========================================== + Hits 12137 12148 +11 Misses 3506 3506 Partials 828 828 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment