knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
353 stars 261 forks source link

Fix package location for build flags #1978

Closed dsimansk closed 4 days ago

dsimansk commented 4 days ago

Description

Changes

Reference

Fixes #

Release Note

 Fix `version` command to dispaly proper version string

/cc @rhuss @cardil

@cardil that's an overlooked issue from the client-pkg migration.

Fixes #1977

dsimansk commented 4 days ago

/cherry-pick release-1.16

knative-prow-robot commented 4 days ago

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to [this](https://github.com/knative/client/pull/1978#issuecomment-2486167993): >/cherry-pick release-1.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/client/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 4 days ago

Thanks @dsimansk for fixing this!

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.70%. Comparing base (f94c31b) to head (b035b75). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1978 +/- ## ======================================= Coverage 73.70% 73.70% ======================================= Files 234 234 Lines 16482 16482 ======================================= Hits 12148 12148 Misses 3506 3506 Partials 828 828 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

knative-prow-robot commented 4 days ago

@dsimansk: new pull request created: #1979

In response to [this](https://github.com/knative/client/pull/1978#issuecomment-2486167993): >/cherry-pick release-1.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.