search

knative / client

Knative developer experience, docs, reference Knative CLI implementation
Apache License 2.0
351 stars 263 forks source link

add WatchService to KnServingClient interface #989

Open ericmillin opened 4 years ago

ericmillin commented 4 years ago

Feature request

Expose the WatchService function via KnServingClient interface. This will make the function available to users outside the project.

Use case

I want to use the kn client to watch services in my own code

rhuss commented 4 years ago

Good idea, lets tackle this for the next release cycle

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

rhuss commented 3 years ago

Not sure if this is already implemented but I still think it is a good idea :-)

/remove-lifecycle-stale

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

rhuss commented 3 years ago

/remove-lifecycle stale

rhuss commented 3 years ago

I think we have now a WatchServiceWithVersion but its not part of the interface (however, a public method). @dsimansk do you think it makes sense to move that to the client interface (and maybe rename it to WatchService ?)