search

knative / community

Knative governance and community material.
https://knative.dev/community
Other
252 stars 234 forks source link

This repo contains golang and should be linted #1276

Open krsna-m opened 1 year ago

krsna-m commented 1 year ago

Look at knative/actions repo and use the reusable golang linter here.

Bisht13 commented 1 year ago

/assign @Bisht13

Bisht13 commented 1 year ago

@kvmware does this require only adding https://github.com/knative/actions/blob/main/.github/workflows/lint.yaml to this repo's GitHub workflows?

krsna-m commented 1 year ago

@Bisht13 One would have to use the reusables (style). See how knative/serving is doing it. The lint.yaml is for the actions repo itself only. The reusable action should already check (double make sure please) that it only runs on golang code changes

dprotaso commented 1 year ago

Is the reusable action able to handle repos with multiple go.mod files?

kauana commented 1 year ago

Hmm the Lint action is not working on the actions repo due to a file rename. I will open an issue on the actions repo to address this