knative / community

Knative governance and community material.
https://knative.dev/community
Other
252 stars 233 forks source link

Add new approvers to eventing-natss #1479

Closed dan-j closed 10 months ago

dan-j commented 10 months ago

@astelmashenko and I have been heavily involved in the improvement of the JetStream support in eventing-natss and would like to become approvers of the project. We're already community members so I believe this is the only change we need to make?

At the moment the only approver is @zhaojizhuang, if you would like to provide your 👍 or some feedback on anything better we can do?

Thanks

knative-prow[bot] commented 10 months ago

Hi @dan-j. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pierDipi commented 10 months ago

/cc @knative/technical-oversight-committee

knative-prow[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dan-j, pierDipi, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[peribolos/OWNERS](https://github.com/knative/community/blob/main/peribolos/OWNERS)~~ [psschwei] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment