Closed converge closed 4 months ago
Welcome @converge! It looks like this is your first PR to knative/community 🎉
Hi @converge. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/lgtm Thanks for all your contributions so far @converge 🎉
/cc @dprotaso
/ok-to-test /lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: converge, dprotaso, pierDipi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes
I'm adding myself as a knative and knative-sandbox member so I don't need to wait for the ok-to-test labels.
My contributions so far have been: eventing eventing-kafka-broker
cc @Cali0707 @pierDipi @davidhadas