knative / community

Knative governance and community material.
https://knative.dev/community
Other
249 stars 232 forks source link

Add nrrso to SC #1521

Closed aliok closed 6 months ago

aliok commented 7 months ago

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 7 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative/community/pull/1521): > > > > ># Changes > > > >- Add nrrso to SC >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 7 months ago

/hold

@nrrso can you verify the email address please? Is that the one that you would like to use?

aliok commented 7 months ago

/unhold

@knative/steering-committee this PR ready to go!

evankanderson commented 6 months ago

/lgtm /approve

I'm not sure if the group add will work in the same pass, but I'm willing to try it.

knative-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/community/blob/main/OWNERS)~~ [aliok,evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 6 months ago

Hey @nrrso you'll have a bunch of org invites - can you approve those soon. This will unblock owner updates across our repos - eg. https://github.com/knative/func/pull/2229#issuecomment-1996227316

dprotaso commented 6 months ago

There will be two invites - one from the knative org and the other from knative-extensions