search

knative / community

Knative governance and community material.
https://knative.dev/community
Other
244 stars 234 forks source link

Add folks from RabbitMQ Team #1534

Closed ikavgo closed 3 months ago

ikavgo commented 3 months ago

Changes

/kind enchancement

Release Note

Add Michal Kuratczyk and Aitor Pérez Cedres from RabbitMQ Team

cc @dprotaso @mkuratczyk

knative-prow[bot] commented 3 months ago

@ikavgo: The label(s) kind/enchancement cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative/community/pull/1534): ># Changes > >/kind enchancement > > >**Release Note** > >```release-note >Add Michal Kuratczyk from RabbitMQ Team >``` > > >cc @dprotaso @mkuratczyk Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 3 months ago

Hi @ikavgo. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ikavgo commented 3 months ago

/ok-to-test

dprotaso commented 3 months ago

After the changes you have to ./hack/update-codegen.sh

ikavgo commented 3 months ago

/lgtm :-)

@dprotaso I think it's mergeble now

dprotaso commented 3 months ago

/lgtm /approve

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ikavgo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[peribolos/OWNERS](https://github.com/knative/community/blob/main/peribolos/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment