search

knative / community

Knative governance and community material.
https://knative.dev/community
Other
244 stars 234 forks source link

Remove emeritus WGs from Peribolos #1547

Closed aliok closed 3 months ago

aliok commented 3 months ago

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 3 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative/community/pull/1547): > > > > ># Changes > > > >- Remove emeritus WGs from Peribolos >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 3 months ago

@cardil @upodroid

I am not 100% sure if the removed things are referenced in any repos. Can they be used in the OWNERS files in repositories? Or, do we manage those files based on the files here and this PR will be just fine?

cardil commented 3 months ago

/hold

cardil commented 3 months ago

@aliok: I am not 100% sure if the removed things are referenced in any repos. Can they be used in the OWNERS files in repositories? Or, do we manage those files based on the files here and this PR will be just fine?

I think only OWNER_ALIASES is synched. The OWNERS file needs to be adjusted if those removed teams are used. IDK, if it will break Prow review suggestions, but I doubt it.

aliok commented 3 months ago

The OWNERS file needs to be adjusted if those removed teams are used. IDK, if it will break Prow review suggestions, but I doubt it.

Do I need to go and check each repo to find out where these deleted teams are used? Or will it be "only" review suggestions that might be broken. If it is the latter, I would want to merge this PR and send an email to knative-dev asking folks to check their own repositories.

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[peribolos/OWNERS](https://github.com/knative/community/blob/main/peribolos/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment