Open aliok opened 3 months ago
@aliok: The label(s) kind/<kind>
cannot be applied, because the repository doesn't have them.
cc @rhuss @dsimansk
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: aliok, rhuss
The full list of commands accepted by this bot can be found here.
The pull request process is described here
New changes are detected. LGTM label has been removed.
Are Roland / David covered as members of client-writers? For example, on quickstart we've explicitly listed them as one of the owners: https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/OWNERS#L4
Yeah let's update the OWNER files in the various repos to add client-writers
I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.
Need rebase
I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.
Thanks for checking. I am closing this one then.
/close
@aliok: Closed this PR.
Maybe I misunderstood...
Can you have a look at https://github.com/knative/community/blob/b056e6e06a8d413a1c40789d86199e592faccd80/peribolos/knative-extensions-OWNERS_ALIASES#L127-L129
Both names there are inactive and to be removed. Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?
cc @dprotaso
Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?
Yes, that's right
Changes