knative / community

Knative governance and community material.
https://knative.dev/community
Other
244 stars 234 forks source link

Add rhuss and dsimansk as approvers to all kn plugins #1548

Open aliok opened 3 months ago

aliok commented 3 months ago

Changes

knative-prow[bot] commented 3 months ago

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative/community/pull/1548): > > > > ># Changes > > > >- Add rhuss and dsimansk as approvers to all kn plugins >- This is necessary to remove some inactive approvers later on >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aliok commented 3 months ago

cc @rhuss @dsimansk

rhuss commented 3 months ago

/approve /lgtm

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[peribolos/OWNERS](https://github.com/knative/community/blob/main/peribolos/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow[bot] commented 3 months ago

New changes are detected. LGTM label has been removed.

psschwei commented 3 months ago

Are Roland / David covered as members of client-writers? For example, on quickstart we've explicitly listed them as one of the owners: https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/OWNERS#L4

dprotaso commented 3 months ago

Yeah let's update the OWNER files in the various repos to add client-writers

psschwei commented 3 months ago

I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.

davidhadas commented 2 months ago

Need rebase

aliok commented 1 month ago

I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.

Thanks for checking. I am closing this one then.

aliok commented 1 month ago

/close

knative-prow[bot] commented 1 month ago

@aliok: Closed this PR.

In response to [this](https://github.com/knative/community/pull/1548#issuecomment-2102550114): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aliok commented 3 weeks ago

Maybe I misunderstood...

Can you have a look at https://github.com/knative/community/blob/b056e6e06a8d413a1c40789d86199e592faccd80/peribolos/knative-extensions-OWNERS_ALIASES#L127-L129

Both names there are inactive and to be removed. Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?

cc @dprotaso

psschwei commented 3 weeks ago

Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?

Yes, that's right