search

knative / community

Knative governance and community material.
https://knative.dev/community
Other
253 stars 235 forks source link

PROCESS CHANGE: Writers or WG leads should get admin powers to repos #1570

Open Cali0707 opened 6 months ago

Cali0707 commented 6 months ago

From discussion on slack, it would be nice for writers (or at least the WG leads) for various areas to be able to do admin-only actions such as /override various tests on a PR.

Expected benefits

Fewer calls to TOC members to /override on PRs, and no need to wait on someone else when something needs to be overriden.

Expected costs

More people will be admins on repos

dsimansk commented 6 months ago

/cc @knative/productivity-leads

Hi folks, is there a viable way to handle such request via Peribolos config?

Cali0707 commented 6 months ago

@dsimansk one way I could think of doing this is, for each repo where currently there is the write permission, changing that to admin. For example, for the eventing writers group we could change the config to:

Eventing Writers:
        description: Grants write access to eventing-related repositories.
        privacy: closed
        repos:
          eventing: admin
          eventing-contrib: admin
          pkg: admin
          release: admin

(This is currently how the release leads group is configured, but they have the admin permission for all repos)

dsimansk commented 6 months ago

@Cali0707 thanks for the pointer. Yep, makes sense to me. Per you proposal, I'd suggest we grant admin perm on Working Group Lead level at least (with a new group ). Then keep write group for Approvers.

We already have team: definition for WG Leads, probably needs a permission assignment. Pending TOC and Productivity WG approval ofc.

/cc @knative/technical-oversight-committee /cc @knative/productivity-leads

psschwei commented 6 months ago

I think we can give non-admins the ability to override via the prow config