knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.5k stars 1.22k forks source link

Website colour adjustments #5765

Closed mmejia02 closed 3 months ago

mmejia02 commented 11 months ago

New colours for the website were chosen to be more accessible and maintain brand consistency. The original dark and light blue used on the website are not the same ones used on the logo. The hex colours and screenshot of current website are below.

image

image

As such the blues were changed to match the logo, but the dark blue was slightly darkened to have sufficient colour contrast to be used as a background colour.

In order for the light blue to be accessible as a background we will need to change the button text to be 18.7 px. but this would be a next step.

Conclusion: Change the root website dark and light blue to the following hex codes:

Light Blue: 6593C8 Dark blue: 0D4984

Cali0707 commented 10 months ago

Thanks for opening this @mmejia02 ! Would you be able to open a similar issue in https://github.com/knative/docs so that a contributor there can work on this?

Cali0707 commented 9 months ago

/good-first-issue

knative-prow[bot] commented 9 months ago

@Cali0707: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative/docs/issues/5765): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ReToCode commented 9 months ago

/cc @knative/steering-committee

lavishpal commented 9 months ago

/assign

github-actions[bot] commented 6 months ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

Cali0707 commented 6 months ago

/remove-lifecycle stale

Cali0707 commented 6 months ago

/triage accepted

asr2003 commented 4 months ago

/assign

asr2003 commented 4 months ago

@Cali0707 Could I change the entire root website dark and light blue as per mentioned HEX Codes

Light Blue: 6593C8 Dark blue: 0D4984

Cali0707 commented 4 months ago

Hey @asr2003 yeah, that sounds like a good approach to me! As a bit of help, since we are using mkdocs I would recommend checking out https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#custom-colors for more info on how to set the root colours of the site

asr2003 commented 4 months ago

Thanks, @Cali0707 . I have done with setup and went through the codebase to better understand current status of project after getting assign of this issue . Now I have got a brief idea about this project. I will now ahead to work on this issue and submit a PR soon .

Will follow up you in Slack for further assistance :)

rohitsrma commented 4 months ago

/assign

Cali0707 commented 4 months ago

Hey @rohitsrma it looks like @asr2003 is already working on this issue. Would you be interested in working on something else instead?

rohitsrma commented 4 months ago

Hello @Cali0707, I'm really sorry for assigning myself.

@asr2003 I've made the changes locally to resolve this issue. So, if you need any help i would be more than happy to do.

rash1411 commented 3 months ago

assign