search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.43k stars 1.23k forks source link

When is it necessary to skip tag to digest resolving? #5853

Closed NohaIhab closed 4 months ago

NohaIhab commented 5 months ago

Describe the change you'd like to see In the docs, there are mentions of tag resolution and why it is done in KNative, but there's no mention of when it is needed to skip tag resolution. I see many issues in the repo where the solution suggested is to to modify the Serving config-deployment configmap to skip tag resolution (examples are https://github.com/knative/serving/issues/13914, https://github.com/knative/serving/issues/6114, https://github.com/knative/serving/issues/9090). The missing information here is what are the use cases when skipping tag resolution is required? or it can be how does tag resolution work so one can understand when they need to skip it?

Cali0707 commented 4 months ago

@dprotaso @ReToCode any ideas?

ReToCode commented 4 months ago

Tag resolution does read the docker image tag you provide and replaces it with the concrete SHA value in the Deployment. The reason for this is, that docker tags are not necessarily unique. Knative makes sure with the SHA that it always deploys exactly the same image.

I don't see an immediate need to skip it. So if you don't know why you would disable that behavior, I'd argue there is no need to disable it.

dprotaso commented 4 months ago

Usually you want to skip it in dev environments - eg. I'm running on kind and I'm preloading images to the the docker vm. Pulling won't work but starting a container will because the image is already on the nodes.

Also some people are using registries with custom ca/self-signed certificates for testing. Rather than configure the controller with the right CA (which we have docs for) people just want to skip this functionality.

Generally it's a bad practice to skip so I don't think we should highlight it.

Let us know if you have anymore questions.