search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

Document how to set Kafka Topic config options #5854

Closed Cali0707 closed 8 months ago

Cali0707 commented 8 months ago

This documents how to set Kafka topic config options on a broker.

Proposed Changes

Note: this should not merge until after https://github.com/knative-extensions/eventing-kafka-broker/pull/3671

netlify[bot] commented 8 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 3127b35628cdf6161ccd78ad771964fa7a88c1f7
Latest deploy log https://app.netlify.com/sites/knative/deploys/65c53197aa5d7c000826c1d8
Deploy Preview https://deploy-preview-5854--knative.netlify.app/docs/eventing/brokers/broker-types/kafka-broker
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Cali0707 commented 8 months ago

/hold until https://github.com/knative-extensions/eventing-kafka-broker/pull/3671

/cc @pierDipi @matzew @Leo6Leo

Cali0707 commented 8 months ago

/cc @pierDipi

knative-prow[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/eventing/OWNERS](https://github.com/knative/docs/blob/main/docs/eventing/OWNERS)~~ [Cali0707,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Cali0707 commented 8 months ago

/unhold The feature is merged now

Cali0707 commented 8 months ago

/cherry-pick release-1.13 /cherry-pick release-1.12

knative-prow-robot commented 8 months ago

@Cali0707: new pull request created: #5859

In response to [this](https://github.com/knative/docs/pull/5854#issuecomment-1936432048): >/cherry-pick release-1.13 >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Cali0707 commented 8 months ago

/cherry-pick release-1.12

knative-prow-robot commented 8 months ago

@Cali0707: new pull request created: #5860

In response to [this](https://github.com/knative/docs/pull/5854#issuecomment-1936434212): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.