search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

queue-sidecar annotations should be defined under spec.template.metad… #5867

Closed mgencur closed 7 months ago

mgencur commented 7 months ago

…ata.annotations

Otherwise they're not propagated to the Revision.

Proposed Changes

netlify[bot] commented 7 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 64630b71bc87ce0c75587734e5f62ca6171bdb8c
Latest deploy log https://app.netlify.com/sites/knative/deploys/65cde78e120a8d0008159988
Deploy Preview https://deploy-preview-5867--knative.netlify.app/docs/serving/services/configure-requests-limits-services
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mgencur commented 7 months ago

/cc @skonto

skonto commented 7 months ago

/lgtm

Wrong pasting :)

skonto commented 7 months ago

/approve

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/serving/OWNERS](https://github.com/knative/docs/blob/main/docs/serving/OWNERS)~~ [skonto] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 7 months ago

Should we cherry pick this back to 1.13 and 1.12 branch?

mgencur commented 7 months ago

Should we cherry pick this back to 1.13 and 1.12 branch?

Yes. I think so.

ReToCode commented 7 months ago

/cherry-pick release-1.12

ReToCode commented 7 months ago

/cherry-pick release-1.13

knative-prow-robot commented 7 months ago

@ReToCode: new pull request created: #5870

In response to [this](https://github.com/knative/docs/pull/5867#issuecomment-1947875571): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 7 months ago

@ReToCode: new pull request created: #5871

In response to [this](https://github.com/knative/docs/pull/5867#issuecomment-1947875660): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.