search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

Implemented sliding animation for the adopter logos #5878

Closed prajjwalyd closed 7 months ago

prajjwalyd commented 7 months ago

Addresses - https://github.com/knative/community/issues/1416

Proposed Changes

I've been working on implementing the sliding animation for the adopters' logos.

scrnli_2_19_2024_1-16-44 AM.webm

I haven't used any external libraries for this... Also, the logos along with their links are dynamically rendered as per the instructions. Public preview link: https://prajjwalyd.github.io/docs/

linux-foundation-easycla[bot] commented 7 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 7 months ago

Welcome @prajjwalyd! It looks like this is your first PR to knative/docs 🎉

netlify[bot] commented 7 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit e93ab910f7d14d0ee387d271a7fcd413d0af5320
Latest deploy log https://app.netlify.com/sites/knative/deploys/65e754488fecd20008ab1541
Deploy Preview https://deploy-preview-5878--knative.netlify.app/docs
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aliok commented 7 months ago

/lgtm /approve

Thanks a lot @prajjwalyd

As we talked in Slack, can you create a ticket for the missing logos? And, also, for any other improvement that you've planned.

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, prajjwalyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [aliok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment