Modify the description about Max revision timeout seconds

KAZYPinkSaurus commented 7 months ago

This PR is related to https://github.com/knative/serving/pull/14969 .

Because TerminationGracePeriodSeconds is more appropriate than terminationGraceTimeSeconds. The document probably explain about fallowing value. https://github.com/knative/serving/blob/6dc7097b740f6b0e6ae744abad5e84338a1b8066/config/core/deployments/activator.yaml#L124

I believe this PR makes this document more understandable.

Thank you.

Proposed Changes

Modified terminationGraceTimeSeconds in the document of Max revision timeout seconds to terminationGracePeriodSeconds.

linux-foundation-easycla[bot] commented 7 months ago

:white_check_mark:login: KAZYPinkSaurus / (cdc3ed9fb6c7b645de329a394a34c1bfd51b7c4d)

The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 7 months ago

Welcome @KAZYPinkSaurus! It looks like this is your first PR to knative/docs 🎉

netlify[bot] commented 7 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name	Link
Latest commit	cdc3ed9fb6c7b645de329a394a34c1bfd51b7c4d
Latest deploy log	https://app.netlify.com/sites/knative/deploys/65e472cd80df450008da6d50
Deploy Preview	https://deploy-preview-5884--knative.netlify.app/docs/serving/configuration/config-defaults
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dprotaso commented 7 months ago

/lgtm /approve /cherry-pick release-1.13

knative-prow-robot commented 7 months ago

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative/docs/pull/5884#issuecomment-1975210210): >/lgtm >/approve >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KAZYPinkSaurus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/serving/OWNERS](https://github.com/knative/docs/blob/main/docs/serving/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative-prow-robot commented 7 months ago

@dprotaso: new pull request created: #5885

In response to [this](https://github.com/knative/docs/pull/5884#issuecomment-1975210210): >/lgtm >/approve >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

knative / docs