search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.41k stars 1.22k forks source link

The min-scale annotation, which is deprecated, has been moved to minScale. #5901

Closed kahirokunn closed 3 months ago

kahirokunn commented 4 months ago

The annotation of these two kebab cases will follow the Camel case since it is the current official support https://github.com/knative/client/pull/1498

Proposed Changes

-

-

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit bad2c624c5c543f6d84db6fe94791c0500665df8
Latest deploy log https://app.netlify.com/sites/knative/deploys/65ebc5eaffb76600081cb6ae
Deploy Preview https://deploy-preview-5901--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn Once this PR has been reviewed and has the lgtm label, please assign mmejia02 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ReToCode commented 4 months ago

/hold

it is the other way around, see https://github.com/knative/serving/issues/12103. The new annotations are the ones with kebab case.