Sample App: Adding the knative function build for the sentiment analysis service

Leo6Leo commented 3 months ago

Fixes #5889

Proposed Changes

The code for the sentiment analysis service, which fits in knative function's python template

netlify[bot] commented 3 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name	Link
Latest commit	69175104ab0f1c65e5b9b74004fe81902cd456ac
Latest deploy log	https://app.netlify.com/sites/knative/deploys/66155159e720c60008c2f77e
Deploy Preview	https://deploy-preview-5904--knative.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Leo6Leo commented 3 months ago

/cc @Cali0707 @pierDipi

Leo6Leo commented 3 months ago

/cc @lkingland @matejvasek

nainaz commented 3 months ago

I agree, and since cold start is already something on the back of customer mind while working with serverless, we should not add extra perception Thank you, -N

On Wed, 20 Mar 2024 at 12:33, Calum Murray @.***> wrote:

@.**** commented on this pull request.

In code-samples/eventing/bookstore-sample-app/ML-sentiment-analysis/README.md https://github.com/knative/docs/pull/5904#discussion_r1532422027:

Sleep for 3 seconds to simulate a long-running process

sleep(3)

I think since this is providing an example of how to build an app with Knative it doesn't necessarily make sense to make it slower just to show that some real world stuff could be slow, so my vote would be to remove it (as long as everything still works without the sleep)

— Reply to this email directly, view it on GitHub https://github.com/knative/docs/pull/5904#discussion_r1532422027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISZCFBLFXZ7CTS63FH7PULYZG25JAVCNFSM6AAAAABEUF5TMCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBZGQ2DCMRYHA . You are receiving this because your review was requested.Message ID: @.***>

Leo6Leo commented 3 months ago

https://github.com/knative/func/issues/2241 has been resolved.

In order to make func invoke work correctly, readers need to install latest knative function when available. (release 1.14)

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [Leo6Leo,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative / docs