search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

Docs: Change namespace-wildcard-cert-selector value type from object to string #5933

Closed hubwoop closed 6 months ago

hubwoop commented 6 months ago

This PR proposes changes the docs on automatic TLS certificate provisioning. In the examples given under "Provisioning certificates per namespace (wildcard certificates)" objects are provided as values for namespace-wildcard-cert-selector, I think only strings can be values for ConfigMap data values. In the next section (Configure config-certmanager ConfigMap) a string is provided.

Proposed Changes

linux-foundation-easycla[bot] commented 6 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 6 months ago

Welcome @hubwoop! It looks like this is your first PR to knative/docs 🎉

netlify[bot] commented 6 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit f7b7d7cb166f593cf527437148c2556e25ffb9c4
Latest deploy log https://app.netlify.com/sites/knative/deploys/660ab5fe6502340008067929
Deploy Preview https://deploy-preview-5933--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pierDipi commented 6 months ago

/cc @ReToCode @skonto @dprotaso

knative-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hubwoop, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/serving/OWNERS](https://github.com/knative/docs/blob/main/docs/serving/OWNERS)~~ [ReToCode] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment