search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.41k stars 1.22k forks source link

Sample App: Code Clean up #5948

Closed Leo6Leo closed 1 month ago

Leo6Leo commented 2 months ago

fixes #5950 fixes #5943 fixes #5880 fixes #5999

We need to tidy up our sample app code! And because each component might be connected, it will be hard to make edit on different PR. Making this huge PR could make the life much easier.

This includes but not limited to:

netlify[bot] commented 2 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 9e282e5836e5c2a7005924aaaac85def2570ff4d
Latest deploy log https://app.netlify.com/sites/knative/deploys/665645e3f619ec00089d08fe
Deploy Preview https://deploy-preview-5948--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Leo6Leo commented 1 month ago

/cc @pierDipi @Cali0707 @creydr

pierDipi commented 1 month ago

/lgtm /approve

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [Leo6Leo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment