search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

Apply New Designs to Case Studies Section #5962

Open rohitsrma opened 4 months ago

rohitsrma commented 4 months ago

In this PR I've implemented the new designs for the case studies section, as provided in the Figma design shared by @mmejia02

Before

Untitled design (1)

After

new (2)

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitsrma Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 0eb6ff2d5a63388093f898515d1a51185e1f02b7
Latest deploy log https://app.netlify.com/sites/knative/deploys/664cf1f17f2e7a0008db7f22
Deploy Preview https://deploy-preview-5962--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shivamgupta2020 commented 4 months ago

@rohitsrma, I think you should fix the following:-

  1. The font style should be changed to Roboto.
  2. In mobile mode, the margin should be increased between two blocks.
  3. the "case study" font and style do not match the design in mobile mode.
knative-prow-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Cali0707 commented 2 months ago

/close this was superceded by #6032