search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.41k stars 1.22k forks source link

fixed the aligment of sponsor section #5963

Open TenzDelek opened 1 month ago

TenzDelek commented 1 month ago

Changes: the current alignment of the sponsor seems to have no margin given resulting in default left and a negative white space.

image

Changes made: made the sponsor section center to the screen for better white space.

image
knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TenzDelek Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 1 month ago

CLA Signed


The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 1 month ago

Welcome @TenzDelek! It looks like this is your first PR to knative/docs 🎉

netlify[bot] commented 1 month ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 8a2355ab8be993bbe6c68cf3b057783866a49999
Latest deploy log https://app.netlify.com/sites/knative/deploys/663f532fa889b2000866586e
Deploy Preview https://deploy-preview-5963--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aliok commented 1 month ago

@TenzDelek I see the adopters are listed fine on https://knative.dev/docs/ page.

Can you check again please?

TenzDelek commented 1 month ago

@TenzDelek I see the adopters are listed fine on https://knative.dev/docs/ page.

Can you check again please?

hey @aliok , I have raised that issue in #5996 and from what I have seen, it is only happening for my device(window). but for my mac, it is working perfectly fine. I guess that problem resides from my end.. Thank you for the concern, this pr can be close :)

aliok commented 1 month ago

@TenzDelek

Hm, interesting. Do you have anything special on your Windows machine? That shouldn't happen on Windows too

TenzDelek commented 1 month ago

@TenzDelek

Hm, interesting. Do you have anything special on your Windows machine? That shouldn't happen on Windows too

@aliok , I don't recall having any specific installation that might raise this behavior. but as per my discussion in the above issue section, other member who are having windows doesn't seem to have this kind of issue. so I guess technically this comes down to my machine. I will try to look further into it. but i find it funny how it only the marquee that is not working? is there any case regarding this in the pass? :)