search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

Redesign How to Get Involved Diagram #5969

Closed rohitsrma closed 1 week ago

rohitsrma commented 4 months ago

Fixes #85

Before

image

After

image

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 8fe90157cfc1e8c04df14f11e0af863c6dc3b48b
Latest deploy log https://app.netlify.com/sites/knative/deploys/6650cc4e7451dd0008ee6438
Deploy Preview https://deploy-preview-5969--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitsrma Once this PR has been reviewed and has the lgtm label, please assign leo6leo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shivamgupta2020 commented 4 months ago

@rohitsrma, I think you should also change the font style. Knative and Kubernetes fonts do not match.

Leo6Leo commented 4 months ago

@rohitsrma Hello Rohit, thank you for your PR. Any changes regarding the design, we should have a discussion with the design leads in the UX WG to ensure it aligns with our branding guideline. I have put this PR to the agenda for the next UX WG meeting.

It is a public meeting, so we encourage you to join us and share your insight with us! You can find the time and zoom link in the meeting note link I shared above.

rohitsrma commented 4 months ago

Thanks a lot, @Leo6Leo! I will definitely join the meeting and look forward to it.

github-actions[bot] commented 1 month ago

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.