search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

fix: Website colour adjustments #5980

Closed asr2003 closed 4 months ago

asr2003 commented 4 months ago

Proposed Changes

linux-foundation-easycla[bot] commented 4 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 06bb021bfcf5dd34e50b47d96c98da90560c1c29
Latest deploy log https://app.netlify.com/sites/knative/deploys/6654a47faddfb6000876554e
Deploy Preview https://deploy-preview-5980--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

asr2003 commented 4 months ago

@Cali0707 It's ready for your review. PTAL

Cali0707 commented 4 months ago

@asr2003 could you sign the CLA? It should be the link in this comment

asr2003 commented 4 months ago

@Cali0707 Done with signing CLA.

aliok commented 4 months ago

@knative/ux-wg-leads is this PR good?

Leo6Leo commented 4 months ago

We will be approving the PRs during our next UX WG meeting. I have put the PR in the meeting agenda.

Update: As the PR is implementing the design that UX WG has agreed on, no need for approval during the meeting.

asr2003 commented 4 months ago

@Leo6Leo Thanks for putting this PR for next UX WG meeting. I will make sure to join the meeting and also I have some enhancements in my mind, can we discuss there or in slack?

Leo6Leo commented 4 months ago

@asr2003 Sure! Feel free to discuss here, or in the CNCF slack #knative-ux channel. If you think it worthy a discussion among the UX WG, you can put it on the UX WG meeting agenda here. Looking forward to having you join in our next meeting.

Leo6Leo commented 4 months ago

/approve /cc @mmejia02 @zainabhusain227

zainabhusain227 commented 4 months ago

Color scheme suggestions (from most recent design system: https://www.figma.com/design/3CzqCQj0dDK1MuTZelUfFa/Knative-Design-System?node-id=101-2&t=CAlyHn4R4uSs4qr9-0)

Changed the root website dark and light blue to the following hex codes: -- Light Blue: #6695CA -- Dark blue: #0865AD

Cali0707 commented 4 months ago

@asr2003 would you mind switching the colours to those @zainabhusain227 listed above?

asr2003 commented 4 months ago

Sure!

asr2003 commented 4 months ago

@zainabhusain227 @Cali0707 Updated with the changes suggested

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asr2003, Cali0707, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [Cali0707,Leo6Leo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
asr2003 commented 4 months ago

@Cali0707 Thanks for merging! I am following up with this PR to get merged from a week. Finally merged :)

Thanks @Cali0707 @Leo6Leo @zainabhusain227 for approving and special thanks to @aliok for an immediate response for getting reviews for this PR.