knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.52k stars 1.23k forks source link

Knative website design issues fixed #5984

Closed nafisreza closed 5 days ago

nafisreza commented 4 months ago

"Implemented website redesign according to issue #134 of knative/ux" I have set up the project locally on my machine and started making improvements according to provided design.

Proposed Changes

Preview:

screencapture-127-0-0-1-8000-docs-2024-05-22-07_03_51

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nafisreza Once this PR has been reviewed and has the lgtm label, please assign krsna-m for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 4 months ago

CLA Signed


The committers listed above are authorized under a signed CLA.

knative-prow[bot] commented 4 months ago

Welcome @nafisreza! It looks like this is your first PR to knative/docs 🎉

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 662d0edde6c5bf8ba549ed1ca9622bf5f8715a03
Latest deploy log https://app.netlify.com/sites/knative/deploys/664d460026d23b0008f796b1
Deploy Preview https://deploy-preview-5984--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aliok commented 4 months ago

hey @nafisreza

This task is part of LFX mentorship project. If you're interested in participating in that program, I would recommend working on your proposal instead of working on the actual task.

Thanks for your contribution! I will keep this PR on hold as I want to spend time on reviewing LFX mentee's PR.

aliok commented 4 months ago

/hold

nafisreza commented 4 months ago

Thanks @aliok for the reply. I have already submitted my proposal on LFX portal along with the necessary docs. Fingers crossed! :)

knative-prow-robot commented 4 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
github-actions[bot] commented 1 month ago

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen with /reopen. Mark as fresh by adding the comment /remove-lifecycle stale.